Align keycloak typings#729
Open
kcinay055679 wants to merge 2 commits into
Open
Conversation
…lignment) Aligns ProvideKeycloakOptions.config type with keycloak-js constructor signature to accept both KeycloakConfig objects and string URLs pointing to keycloak.json configuration files. Fixes mauriciovigolo#657 Co-authored-by: DaSchTour <1907266+DaSchTour@users.noreply.github.com>
Author
|
this is a one on one copy of DaSchTour#2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What is the current behavior?
The current typings for
provideKeycloakdo not allow passing a string URL as theconfigvalue, even though this usage is supported at runtime.Issue Number: #657
What is the new behavior?
Updates the typings to allow string URLs to be used as the
configvalue inprovideKeycloak, for example:Adds/updates tests to cover this behavior.
Does this PR introduce a breaking change?
Other information
This change aligns the typings with the existing runtime behavior.